Add withTracingSupport #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

adam-fowler wants to merge 2 commits into main from with-distributed-tracing

Collaborator

adam-fowler commented Dec 14, 2025

This should make it easier to add distributed tracing to pipeline and transaction


          Add withTracingSupport

d761cf2

Signed-off-by: Adam Fowler <adamfowler71@gmail.com>

github-actions bot commented Dec 14, 2025 •

edited

Loading

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host 'fdc6a8367920' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	51	52	53	54	55	55	55	6
pull_request	49	53	54	55	57	57	57	6
Δ	-2	1	1	1	2	2	2	0
Improvement %	4	-2	-2	-2	-4	-4	-4	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	49	53	54	56	58	62	62	21
pull_request	51	52	54	55	59	63	63	28
Δ	2	-1	0	-1	1	1	1	7
Improvement %	-4	2	0	2	-2	-2	-2	7

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	4	4	8
pull_request	4	4	4	4	4	4	4	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	7	8	9	9	9	9	8
pull_request	4	7	8	9	9	9	9	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	9	20	24	26	27	27	27	8
pull_request	9	20	24	26	27	27	27	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	7	24	24	25	25	25	25	8
pull_request	7	24	24	25	25	25	25	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	16
pull_request	0	0	0	0	0	0	0	18
Δ	0	0	0	0	0	0	0	2
Improvement %	0	0	0	0	0	0	0	2

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	839
pull_request	0	0	0	0	0	0	0	826
Δ	0	0	0	0	0	0	0	-13
Improvement %	0	0	0	0	0	0	0	-13

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	2010
pull_request	0	0	0	0	0	0	0	1994
Δ	0	0	0	0	0	0	0	-16
Improvement %	0	0	0	0	0	0	0	-16

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	377
pull_request	0	0	0	0	0	0	0	375
Δ	0	0	0	0	0	0	0	-2
Improvement %	0	0	0	0	0	0	0	-2


          Add sending to return value

f625be5

Signed-off-by: Adam Fowler <adamfowler71@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet